Skip to content
This repository has been archived by the owner on Dec 1, 2018. It is now read-only.

Heapster should handle duplicated stats from kubelet gracefully #1697

Closed
fgrzadkowski opened this issue Jun 22, 2017 · 9 comments · Fixed by #1807
Closed

Heapster should handle duplicated stats from kubelet gracefully #1697

fgrzadkowski opened this issue Jun 22, 2017 · 9 comments · Fixed by #1807

Comments

@fgrzadkowski
Copy link
Contributor

Ref kubernetes/kubernetes#47853

@piosz
Copy link
Contributor

piosz commented Jun 26, 2017

@loburm could you please take a look? Thanks!

@DirectXMan12
Copy link
Contributor

we need to make sure we log this if it happens, among other things. In the past, we've had too many spots in the collection code which silently ignores errors or missing data.

@DirectXMan12
Copy link
Contributor

DirectXMan12 commented Jun 26, 2017

@piosz: it looks @loburm isn't yet on the list of people that I can assign to

@piosz
Copy link
Contributor

piosz commented Jun 26, 2017

@DirectXMan12 I asked Filip to add him to heapster-reviewers team.

@fgrzadkowski fgrzadkowski assigned loburm and unassigned ghost Jun 27, 2017
@fgrzadkowski
Copy link
Contributor Author

@DirectXMan12 @piosz Fixed.

@piosz
Copy link
Contributor

piosz commented Jun 28, 2017

@fgrzadkowski thx

@loburm
Copy link
Contributor

loburm commented Jul 20, 2017

With #1708 merged, I'm closing this issue.

@loburm loburm closed this as completed Jul 20, 2017
@piosz
Copy link
Contributor

piosz commented Aug 30, 2017

Unfortunately this is not fixed yet. We've seen duplicated containers with non-zero resource usage. Will send a fix soon.

@piosz
Copy link
Contributor

piosz commented Sep 1, 2017

#1790 fixed the problem in 1.4. Decreasing the priority - we need to fix this in HEAD as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants