Skip to content
This repository has been archived by the owner on May 22, 2020. It is now read-only.

cluster-installer - machine delete should wait for finalizers to finish before returning success #390

Closed
ajitak opened this issue Nov 14, 2017 · 3 comments

Comments

@ajitak
Copy link
Contributor

ajitak commented Nov 14, 2017

When a machine CRD is marked for deletion, finalizers should delete node vm. Cluster installer should wait for finalizers to finish deleting vm whenever delete machine code path is triggered.

@ajitak
Copy link
Contributor Author

ajitak commented Nov 27, 2017

@pipejakob
Copy link
Contributor

I had this working a while ago before we froze the prototype code in preparation for the KubeCon event, but it was rolled into work for #355 as well. I still have the code if anyone is interested in referencing it, but it will need a lot of rebasing after the recent refactoring to do proper Machine reconciliation and parallel Machine handling. For now, though, I am unassigning the issue from myself since I am now focused on Istio work.

@rsdcastro
Copy link

This issue was moved to kubernetes-sigs/cluster-api#12

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants