Skip to content
This repository has been archived by the owner on May 22, 2020. It is now read-only.

MachineSet implementation for scaling up & down #536

Closed
rsdcastro opened this issue Jan 29, 2018 · 2 comments
Closed

MachineSet implementation for scaling up & down #536

rsdcastro opened this issue Jan 29, 2018 · 2 comments

Comments

@rsdcastro
Copy link

Some thoughts/questions:

  • Choose a specific instance to remove rather than arbitrary instance
  • Does scaling down use any smart logic to pick the node to remove?
  • Does scaling down drain nodes by default? (But allow removing machines w/o draining)
@rsdcastro rsdcastro added this to the cluster-api-beta milestone Feb 2, 2018
@roberthbailey
Copy link
Contributor

We should definitely support removing a specific machine from the set. This isn't supported today in replica sets so there isn't precedence in that API (although customers have asked for it) but it is required by the cluster autoscaler.

Ideally scaling down would choose the best node to remove from the cluster. The cluster autoscaler has code that does this, so it might be possible to reuse that here. For the initial implementation (alpha) we can just pick one randomly.

I'm of the opinion that scaling down should drain by default but allow a "force delete" which skips draining.

@rsdcastro
Copy link
Author

This issue was moved to kubernetes-sigs/cluster-api#27

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants