Skip to content
This repository has been archived by the owner on May 22, 2020. It is now read-only.

Run more automated checks on kube-deploy repo #613

Closed
5 tasks
krousey opened this issue Feb 15, 2018 · 3 comments
Closed
5 tasks

Run more automated checks on kube-deploy repo #613

krousey opened this issue Feb 15, 2018 · 3 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@krousey
Copy link
Contributor

krousey commented Feb 15, 2018

We should run the following checks on PRs and in CI:

  • go vet
  • gofmt
  • verify vendor depencies are correct (this is partially accomplished by build today, but it'd be nice to have better messaging around this)
  • code doesn't need to be regenerated (deepcopy, conversion, clients, ...)
  • BUILD files don't have to be regenerated
@krousey krousey added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Feb 15, 2018
@vaibhavsingh97
Copy link

Hi @krousey Can I take this issue? Any resources to fix this issue will be a great help :)

@krousey
Copy link
Contributor Author

krousey commented Feb 16, 2018

@vaibhavsingh97 Sure! go vet and go fmt would be the easiest to start with, and they cover areas that aren't someone protected against by our current CI build and test.

I started a CI scripts directory here: https://github.com/kubernetes/kube-deploy/tree/master/scripts

Here are the PRs I submitted to turn on build and testing in CI and on PRs. Hopefully that will be instructive enough.

Also, if you're running the scripts locally, I would recommend Go 1.9+ because they changed the way go tools handle the vendor directory to make it easier.

@rsdcastro
Copy link

This issue was moved to kubernetes-sigs/cluster-api#43

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

3 participants