Skip to content
This repository has been archived by the owner on May 22, 2020. It is now read-only.

MachineSet controller listens for Machine resources. #643

Closed
p0lyn0mial opened this issue Mar 8, 2018 · 2 comments
Closed

MachineSet controller listens for Machine resources. #643

p0lyn0mial opened this issue Mar 8, 2018 · 2 comments

Comments

@p0lyn0mial
Copy link
Contributor

p0lyn0mial commented Mar 8, 2018

The current implementation of MachineSet controller watches only the desired state of the cluster. This approach is not sufficient as there are other actors in the system that can easily change the current state (e.g. delete/add a Machine) of the cluster. Thus adding event handlers for Machines to our MachineSet along with appropriate handlers (requeue) seems to be valid approach.

See also:
#535
#620 (comment)
https://github.com/kubernetes/community/blob/master/contributors/devel/controllers.md

@p0lyn0mial
Copy link
Contributor Author

/cc @rsdcastro @mvladev

@rsdcastro
Copy link

This issue was moved to kubernetes-sigs/cluster-api#53

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants