Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Allow relative urls in index.yaml #21

Closed
sebastien-prudhomme opened this issue Jan 25, 2019 · 5 comments
Closed

Allow relative urls in index.yaml #21

sebastien-prudhomme opened this issue Jan 25, 2019 · 5 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@sebastien-prudhomme
Copy link
Contributor

Hi, since Helm 2.5.0, it's possible to use relative urls in index.yaml chart repository: https://github.com/helm/helm/blob/master/docs/chart_repository_faq.md

Minibroker is not compatible with that mode.

In pkg/helm/helm.go, the LoadChart function should first check if chartURL is a fully qualified URL, if not, build an URL with the relative URL and "repoURL".
@carolynvs carolynvs added kind/feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Jan 25, 2019
@carolynvs
Copy link
Contributor

Cool! Let me know if you are interested in working on it too. Otherwise, this is up for grabs for anyone who'd like a good first PR.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 18, 2019
@carolynvs
Copy link
Contributor

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 18, 2019
@KamalSinghKhanna
Copy link

hey! I am new here would like to work on this issue. please guide me how to get started?

@mrbobbytables
Copy link

This project is being archived, closing open issues and PRs.
Please see this PR for more information: kubernetes/community#6632

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@sebastien-prudhomme @carolynvs @mrbobbytables @k8s-ci-robot @fejta-bot @KamalSinghKhanna