Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

HNC: webhooks are not created/deleted as watched types are modified #761

Closed
adrianludwin opened this issue May 25, 2020 · 2 comments · Fixed by #790
Closed

HNC: webhooks are not created/deleted as watched types are modified #761

adrianludwin opened this issue May 25, 2020 · 2 comments · Fixed by #790
Assignees
@adrianludwin @yiqigao217
Milestone
hnc-v0.5

Comments

@adrianludwin
Copy link
Contributor

/assign @adrianludwin

I just noticed that while the object reconcilers are created dynamically as a result of the HNC config, the admission controllers are not - there's a hardcoded list left over from v0.2 (and one of them is spelled incorrectly). We should fix this before v0.4.
@adrianludwin adrianludwin added this to the hnc-v0.4 milestone May 25, 2020
@adrianludwin
Copy link
Contributor Author

Sadly, I think we're out of time for v0.4. We'll fix this in v0.5.

@adrianludwin adrianludwin modified the milestones: hnc-v0.4, hnc-v0.5 May 29, 2020
@yiqigao217
Copy link
Contributor

/assign @yiqigao217
FYI working on this now.

This was referenced Jun 5, 2020
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@adrianludwin adrianludwin

@yiqigao217 yiqigao217

Labels
None yet
Projects
None yet
Milestone
hnc-v0.5
Development

Successfully merging a pull request may close this issue.

Enable object webhooks dynamically based on hncconfig yiqigao217/multi-tenancy
2 participants
@adrianludwin @yiqigao217