Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the current group (about.k8s.io) for clusterproperty API accurate? #9

Closed
mikeshng opened this issue Jun 15, 2022 · 1 comment · Fixed by #11
Closed

Is the current group (about.k8s.io) for clusterproperty API accurate? #9

mikeshng opened this issue Jun 15, 2022 · 1 comment · Fixed by #11

Comments

@mikeshng
Copy link
Member

The clusterproperty API group is currently defined as group: about.k8s.io
https://github.com/kubernetes-sigs/about-api/blob/master/clusterproperty/config/crd/bases/about.k8s.io_clusterproperties.yaml#L10

But as stated in KEP k8s.io group protection https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/2337-k8s.io-group-protection/README.md
This group should be protected unless there is an annotation with the PR attached.
The current kustomize patch annotation points to a not related API (default template value?): https://github.com/kubernetes/kubernetes/pull/78458
https://github.com/kubernetes-sigs/about-api/blob/master/clusterproperty/config/crd/patches/annotation_for_clusterproperties.yaml#L6

Should the clusterproperty API group be x-k8s.io instead?

@lauralorenz
Copy link
Contributor

about.k8s.io is correct, but the patch annotation is the wrong link. Our API approval PR is kubernetes/enhancements#3084

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants