Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubernetes 1.11 has removed ExternalID #503

Merged
merged 3 commits into from
Jul 31, 2018
Merged

Kubernetes 1.11 has removed ExternalID #503

merged 3 commits into from
Jul 31, 2018

Conversation

lareeth
Copy link

@lareeth lareeth commented Jul 30, 2018

To try and fix #502

I'm not sure if we should separate the kubelet version check into a helper function.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 30, 2018
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 31, 2018
@coveralls
Copy link

coveralls commented Jul 31, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 23.362% when pulling c97591a on lareeth:feature/kubelet-110-providerid into a6565ea on kubernetes-sigs:master.

@bigkraig bigkraig merged commit dcf3d44 into kubernetes-sigs:master Jul 31, 2018
@bigkraig
Copy link

@lareeth My EKS cluster has IDs like aws:///us-west-2c/i-0f4fd41e227b96c96, which needs a 3 not a 2. What does yours look like? Is it better to do len()-1?

@lareeth
Copy link
Author

lareeth commented Jul 31, 2018

Mine has this same format aws:///eu-central-1b/i-098f46ed55329bc32 and had no issue

But you are right, we should always take the last element

bigkraig added a commit that referenced this pull request Oct 1, 2018
@bigkraig
Merge pull request #503 from lareeth/feature/kubelet-110-providerid
5510e93 
Kubernetes 1.11 has removed ExternalID
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigkraig bigkraig Awaiting requested review from bigkraig

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kubernetes 1.11 has deprecated ExternalID
4 participants
@lareeth @coveralls @bigkraig @k8s-ci-robot