Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feedback Requested] Intent to default to EKS-D sidecars #1456

Closed
ConnorJC3 opened this issue Dec 7, 2022 · 4 comments · Fixed by #1475
Closed

[Feedback Requested] Intent to default to EKS-D sidecars #1456

ConnorJC3 opened this issue Dec 7, 2022 · 4 comments · Fixed by #1475

Comments

@ConnorJC3
Copy link
Contributor

ConnorJC3 commented Dec 7, 2022

We plan to switch the default sidecar images from our current sidecar images (hosted on GCR) to sidecars from the EKS-Distro project (hosted on ECR) in the near future (likely release 1.15.0, which will be available in January).

The GCR overlay will continue to use the existing sidecar images and will not be switched. We we bump the version on these sidecars on a best-effort basis, but will no longer release any custom versions with fixes.

Please use this issue to provide any comments or feedback on this change.

@ConnorJC3 ConnorJC3 pinned this issue Dec 7, 2022
@gnufied
Copy link
Contributor

gnufied commented Dec 7, 2022

Can you start with an outline of underlying reasoning that prompted this decision?

@ConnorJC3
Copy link
Contributor Author

  1. These are the images used by the EKS-managed version of the driver, and we'd like to move towards keeping those versions as close to in sync as reasonably possible (this is the primary reason).
  2. Conformity with other CSI drivers for AWS products such as the EFS CSI Driver.
  3. Their images more closely resemble our own (such as being based on Amazon Linux and hosted on ECR), which has minor space and security benefits.

@olemarkus
Copy link

What does it mean to "switch" sidecar images? Given that this is a Kubernetes SIG project and not an AWS project as such, at least helm chart and e2e tests should at minimum contain tests using the upstream images. I am perfectly fine with offering a separate values file with the EKS-D images though.

@ConnorJC3
Copy link
Contributor Author

ConnorJC3 commented Dec 7, 2022

What does it mean to "switch" sidecar images?

Sorry, slightly bad wording on my part. We'd like to switch the default sidecars for the Helm chart (and ECR overlay for the manual manifests) to the EKS-D versions, such as how the EFS driver currently does it (or how the Azuredisk CSI Driver does it for sidecars hosted on MCR).

No changes will be made to the parameter names or how they work, so users can override this default with any sidecars they wish.

EDIT: changed the issue title and description to make it more clear we want to change the default, not start hardcoding the sidecars or something weird like that.

@ConnorJC3 ConnorJC3 changed the title [Feedback Requested] Intent to switch to EKS-D sidecars [Feedback Requested] Intent to default to EKS-D sidecars Dec 7, 2022
@torredil torredil unpinned this issue Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants