-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service Monitor #3694
Comments
Yes, I'll take this |
/assign |
6 tasks
ping @rjop-hccgt |
thanks @omerap12 |
@rjop-hccgt, @omerap12, I think this is on purpose to avoid double scraping by prometheus, see: #2601 |
Hey @oliviassss , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
I believe there is an issue with the Helm chart, particularly in this line (https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/main/helm/aws-load-balancer-controller/templates/deployment.yaml#L30). I think the logic should be inverted and the prometheus labels should be added only when the
.Values.serviceMonitor.enabled
flag is set totrue
Steps to reproduce
serviceMonitor.enabled
totrue
.helm template ./ --values values.yaml | kubectl apply -f -
Expected outcome
The AWS Load Balancer controller deployment shouldn't have the prometheus annotations enabled.
Environment
Additional Context:
The text was updated successfully, but these errors were encountered: