Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

Rename type Files into File #169

Closed
fabriziopandini opened this issue Aug 23, 2019 · 6 comments · Fixed by #171
Closed

Rename type Files into File #169

fabriziopandini opened this issue Aug 23, 2019 · 6 comments · Fixed by #171
Assignees
@SataQiu
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@fabriziopandini
Copy link
Contributor

/kind bug

What steps did you take and what happened:
KubeadmConfig object contains a field Files []Files which I feel a little bit awkward considering that the Files type actually describes a single additional file.

What did you expect to happen:
The Files type be renamed into File (singular)
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 23, 2019
@ncdc ncdc added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 23, 2019
@detiber
Copy link
Contributor

detiber commented Aug 23, 2019

Just wanted to add a note that since this affects the API types, this change could only land with a version targeting a new API version.

@ncdc
Copy link
Contributor

ncdc commented Aug 23, 2019

As long as this gets in before we release v1alpha2, we can do this, right?

@SataQiu
Copy link
Contributor

SataQiu commented Aug 23, 2019

If no one claims it, I'd like to pick it up.
Wait a while for new contributors!
Feel free to self-assign :)

@ncdc
Copy link
Contributor

ncdc commented Aug 23, 2019

Please feel free to take it on

@detiber
Copy link
Contributor

detiber commented Aug 23, 2019 •
edited

As long as this gets in before we release v1alpha2, we can do this, right?

Correct, just wanted to make it clear that if it didn't make the release it would have to wait for v1alpha3 :)

@SataQiu SataQiu mentioned this issue Aug 24, 2019
Merged
@SataQiu
Copy link
Contributor

SataQiu commented Aug 24, 2019

/assign
/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Aug 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@SataQiu SataQiu

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename type Files to File SataQiu/cluster-api-bootstrap-provider-kubeadm
5 participants
@ncdc @detiber @fabriziopandini @SataQiu @k8s-ci-robot