Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capi-operator deployment needs proper ready signal for helm #537

Closed
dtzar opened this issue May 24, 2024 · 3 comments
Closed

Capi-operator deployment needs proper ready signal for helm #537

dtzar opened this issue May 24, 2024 · 3 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@dtzar
Copy link

dtzar commented May 24, 2024 •
edited
Loading

What steps did you take and what happened:
Deployed CAPI-operator see #532 and we discovered that part of the reason why the provider was failing to install was due to capi-operator being started, but not fully ready for the provider and then the provider fails to install. This was resolved by manually putting in a sleep job in helm.

What did you expect to happen:
The capi-operator pods/services have a proper health/readiness check so that providers don't run into failure cases.

Environment:

  • Cluster-api-operator version: 0.10.1
  • Cluster-api version: 1.7.2
  • Minikube/KIND version: 1.29.2
  • Kubernetes version: (use kubectl version): 1.30.0
  • OS (e.g. from /etc/os-release): WSL ubuntu 22.04

/kind bug

Related to #532
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 24, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If CAPI Operator contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dtzar dtzar changed the title Capi-operator deployment has proper ready signal to helm Capi-operator deployment needs proper ready signal for helm May 24, 2024
@dtzar
Copy link
Author

dtzar commented Jun 3, 2024

Related to #406

@dtzar
Copy link
Author

dtzar commented Jun 3, 2024

Closing as I think the --wait covers this

@dtzar dtzar closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dtzar @k8s-ci-robot