Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build NAT gateways in parallel #1792

Closed
randomvariable opened this issue Jul 7, 2020 · 4 comments · Fixed by #1805
Closed

Build NAT gateways in parallel #1792

randomvariable opened this issue Jul 7, 2020 · 4 comments · Fixed by #1805
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.

Comments

@randomvariable
Copy link
Member

/kind bug

What steps did you take and what happened:
[A clear and concise description of what the bug is.]
Combination of #1752 and lack of parallel NAT gateway creation increases the cluster creation time significantly, failing e2e tests. #1789 works around this, but we should be testing multi-AZ anyway.

Having NAT gateways build in parallel or otherwise having the controller return and reconcile would speed up cluster creation sufficiently.

What did you expect to happen:

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Cluster-api-provider-aws version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 7, 2020
@detiber
Copy link
Member

detiber commented Jul 7, 2020

I don't necessarily know if building them in parallel is what we need, or refactoring to create all needed NAT Gateways, Subnets, and other resources that we need multiple of during the course of reconciliation prior to any waiting that is done.

Either way +1 to the idea of minimizing the wait time needed for creating multiple instances of a type of resource without increasing the reconciliation time linearly with the number of instances wherever we can.

@randomvariable
Copy link
Member Author

or refactoring to create all needed NAT Gateways, Subnets, and other resources that we need multiple of during the course of reconciliation prior to any waiting that is done.

Yup, I meant that the effect would be parallel NAT gateway creation, thanks for clarifying!

@gab-satchi
Copy link
Member

/assign
/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Jul 8, 2020
@randomvariable
Copy link
Member Author

Maybe worth holding on #1752, as it will likely conflict?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants