Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile targets fails with setup-envtest not exist error #3386

Closed
sedefsavas opened this issue Apr 4, 2022 · 5 comments · Fixed by #3387
Closed

Makefile targets fails with setup-envtest not exist error #3386

sedefsavas opened this issue Apr 4, 2022 · 5 comments · Fixed by #3387
Assignees
@Skarlso
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sedefsavas
Copy link
Contributor

On a clean checkout, I hit the following issue when I run several targets:

➜  cluster-api-provider-aws git:(b0388430)  make release-changelog  (or create-gh-release)
./hack/releasechangelog.sh -v v1.4.0 -pv v1.3.0 -gh hack/tools/bin/gh -ghorg kubernetes-sigs -ghrepo cluster-api-provider-aws -cimg gcr.io/k8s-staging-cluster-api-aws/cluster-api-aws-controller > out/CHANGELOG.md
bash: /Users/ssavas/dev/CAPA/v1.4.0/cluster-api-provider-aws/hack/tools/bin/setup-envtest-v0.0.0-20211110210527-619e6b92dab9: No such file or directory

Having setup-envtest is not a requirement for those targets so should not see this error.
This issue goes away after running make test as setup-envtest gets added to bin folder.

This bug is introduced with #3362
/kind bug
/triage accepted
/priority important-soon
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Apr 4, 2022
@sedefsavas
Copy link
Contributor Author

cc @Skarlso

@Skarlso
Copy link
Contributor

Skarlso commented Apr 4, 2022

Huh. :O Oh dang, how the... I'll investigate ASAP.

Thank you for pinging.

@Skarlso
Copy link
Contributor

Skarlso commented Apr 4, 2022

/assign

@Skarlso
Copy link
Contributor

Skarlso commented Apr 4, 2022

Oh I see what's wrong. I'll do some shuffling, and then it should be okay. 🤞 :D

@Skarlso Skarlso mentioned this issue Apr 4, 2022
Merged
4 tasks
@Skarlso
Copy link
Contributor

Skarlso commented Apr 4, 2022

Have a fix up. @sedefsavas thanks for reporting! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Skarlso Skarlso

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only setup setup-envtest when the test target is called Skarlso/cluster-api-provider-aws
3 participants
@Skarlso @k8s-ci-robot @sedefsavas