Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

standardize makefile to look more like a kubebuilder Makefile #970

Closed
chuckha opened this issue Aug 7, 2019 · 3 comments · Fixed by #1076
Closed

standardize makefile to look more like a kubebuilder Makefile #970

chuckha opened this issue Aug 7, 2019 · 3 comments · Fixed by #1076
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
v0.4.x

Comments

@chuckha
Copy link
Contributor

chuckha commented Aug 7, 2019

/kind feature

Describe the solution you'd like
The makefile for this provider should look more like the makefile we expect from a kubebuilder project.

As we are using bazel this likely will only have the same targets but use our bazel build to build a given target.

I'd recommend generating a new Makefile with kubebuilder and then porting functionality to it from our current makefile/bazel build.
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 7, 2019
@chuckha chuckha mentioned this issue Aug 9, 2019
Closed
6 tasks
@chuckha
Copy link
Contributor Author

chuckha commented Aug 12, 2019

/priority longterm-important

@chuckha
Copy link
Contributor Author

chuckha commented Aug 12, 2019

/milestone v0.4

@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Aug 12, 2019
@chuckha
Copy link
Contributor Author

chuckha commented Aug 12, 2019

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Aug 12, 2019
@vincepri vincepri mentioned this issue Aug 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
v0.4.x
Development

Successfully merging a pull request may close this issue.

✨Remove vendor and Bazel vincepri/cluster-api-provider-aws
3 participants
@ncdc @chuckha @k8s-ci-robot