Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to CAPI v1.3 #248

Closed
chrisdoherty4 opened this issue May 9, 2023 · 5 comments
Closed

Upgrade to CAPI v1.3 #248

chrisdoherty4 opened this issue May 9, 2023 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@chrisdoherty4
Copy link
Member

Summary

CAPC v0.4 uses CAPI v1.2. To provide users with at least 1 CAPC release using CAPI 1.3, I'm proposing we do a v0.5 release that uses CAPI 1.3 before upgrading to CAPI 1.4.

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 9, 2023
@chrisdoherty4
Copy link
Member Author

/milestone v0.5

@weizhouapache
Copy link
Collaborator

@chrisdoherty4
Imho, we can skip CAPI 1.3 and upgrade to CAPI 1.4 in 0.5.0 release.

@chrisdoherty4
Copy link
Member Author

I was giving thought to users who want to upgrade CAPC but are using CAPI 1.3. Going through the motions of 1.3 then 1.4 would give them an upgrade path.

Are you saying we shouldn't worry?

@chrisdoherty4
Copy link
Member Author

I took a look at the changes between CAPI versions and what we're using in CAPC and I think upgrading straight to 1.4 is OK.

@weizhouapache
Copy link
Collaborator

@chrisdoherty4
thanks for the checking

I used CAPC v0.4.8 with various clusterctl versions (1.2,1.3,1.4) without any issue
I also noticed aws eks use capi 1.3 and capc 0.4.8-rc1
https://github.com/aws/eks-anywhere/blob/main/go.mod#L62

it may be not required to use the same capi version in capc.
we could test the compatilibity when capc v0.5.0 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants