Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create DigitalOcean Secret properly if cluster is not deployed in kube-system namespace #94

Closed
2 tasks
xmudrii opened this issue Oct 10, 2018 · 1 comment · Fixed by #126
Closed
2 tasks

Create DigitalOcean Secret properly if cluster is not deployed in kube-system namespace #94

xmudrii opened this issue Oct 10, 2018 · 1 comment · Fixed by #126
Assignees
@xmudrii
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v1beta1

Comments

@xmudrii
Copy link
Member

xmudrii commented Oct 10, 2018 •
edited

User story

We're creating a Secret with DigitalOcean API access token in the same namespace as the Cluster object. That Secret is used by Cluster-API Controllers to communicate with the DigitalOcean API.

However, the same Secret is used by DigitalOcean components, including DO Cloud Controller Manager and DO CSI plugin, which are deployed in kube-system namespace by default.

If Cluster is not deployed in kube-system namespace, Secret will not be deployed in kube-system namespace, and CCM and CSI would fail to start.

Acceptance criteria

  • DigitalOcean Secret is created in both kube-system and Cluster namespace.
  • CCM and CSI work as expected when cluster is not deployed in kube-system namespace.
@xmudrii xmudrii added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Oct 10, 2018
@xmudrii xmudrii added this to the v1beta1 milestone Oct 10, 2018
@xmudrii xmudrii added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Oct 10, 2018
@xmudrii xmudrii removed the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Jan 3, 2019
@xmudrii
Copy link
Member Author

xmudrii commented Jan 3, 2019

/lifecycle active
/assign

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Jan 3, 2019
@xmudrii xmudrii mentioned this issue Jan 3, 2019
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xmudrii xmudrii

Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v1beta1
Development

Successfully merging a pull request may close this issue.

Migrate to CRDs, Kubebuilder and Kustomize xmudrii/cluster-api-provider-digitalocean
2 participants
@xmudrii @k8s-ci-robot