You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What steps did you take and what happened:
[A clear and concise description of what the bug is.]
run make lint
What did you expect to happen:
I expected the errors that were shown on an open pull request to be present on the screen.
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
The linter that comes with the project appears to be v1.57.2. If we run this version we will see
Error: unknown linters: 'canonicalheader,fatcontext', run 'golangci-lint help linters' to see the list of supported linters
Failed executing command with error: unknown linters: 'canonicalheader,fatcontext', run 'golangci-lint help linters' to see the list of supported linters
These linters were added in golangci-lint v1.58.0 and v1.58.2. The version that comes in hack/tools/bin is 1.57.2 and the default version in the makefile points to 1.57.2. If I download 1.58.2 and move it to the bin and change the default version I am able to see the errors I expected.
Environment:
Cluster-api version:
Minikube/KIND version:
Kubernetes version: (use kubectl version):
WARNING: This version information is deprecated and will be replaced with the output from kubectl version --short. Use --output=yaml|json to get the full version.
Client Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.4", GitCommit:"795bf1a6260847ecfc612da2ab11ea2d6e07da16", GitTreeState:"clean", BuildDate:"2023-09-19T03:35:46Z", GoVersion:"go1.20.5 X:strictfipsruntime", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v5.0.1
Server Version: version.Info{Major:"1", Minor:"28", GitVersion:"v1.28.9+416ecaf", GitCommit:"922efb2e165deb536505cab2f1d98a6a3146f766", GitTreeState:"clean", BuildDate:"2024-05-08T14:13:08Z", GoVersion:"go1.20.12 X:strictfipsruntime", Compiler:"gc", Platform:"linux/amd64"}
OS (e.g. from /etc/os-release): Fedora 38
The text was updated successfully, but these errors were encountered:
/kind bug
What steps did you take and what happened:
[A clear and concise description of what the bug is.]
run
make lint
What did you expect to happen:
I expected the errors that were shown on an open pull request to be present on the screen.
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
The linter that comes with the project appears to be v1.57.2. If we run this version we will see
These linters were added in golangci-lint v1.58.0 and v1.58.2. The version that comes in hack/tools/bin is 1.57.2 and the default version in the makefile points to 1.57.2. If I download 1.58.2 and move it to the bin and change the default version I am able to see the errors I expected.
Environment:
kubectl version
):/etc/os-release
): Fedora 38The text was updated successfully, but these errors were encountered: