Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push latest image to quay.io via CI process #116

Closed
gyliu513 opened this issue May 5, 2019 · 15 comments
Closed

Push latest image to quay.io via CI process #116

gyliu513 opened this issue May 5, 2019 · 15 comments
Assignees
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/bug Categorizes issue or PR as related to a bug.

Comments

@gyliu513
Copy link
Contributor

gyliu513 commented May 5, 2019

/kind bug
/sig ibmcloud

We should always push controller and clusterctl to quay.io via CI process.

Controller

quay.io/cluster-api-provider-ibmcloud/controller

Clusterctl

quay.io/cluster-api-provider-ibmcloud/clusterctl

@morvencao

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. area/provider/ibmcloud Issues or PRs related to ibmcloud provider labels May 5, 2019
@xunpan
Copy link
Contributor

xunpan commented May 5, 2019

@gyliu513 as we already under account cluster-api-provider-ibmcloud, shall we use names controller and clusterctl for simple. Especially for clusterctl, I think it is better descriptive in docker run quay.io/cluster-api-provider-ibmcloud/clusterctl ...

@gyliu513
Copy link
Contributor Author

gyliu513 commented May 5, 2019

@xunpan +1 to use simple name, you can create PR to fix this.

@jichenjc
Copy link
Contributor

jichenjc commented May 5, 2019

+1 to the simple naming given the namespace we added

@gyliu513
Copy link
Contributor Author

gyliu513 commented May 6, 2019

@xunpan can you help check how federation v2 push the latest image to quay.io? We can follow same way for ibmcloud.

/assign @xunpan

@xunpan
Copy link
Contributor

xunpan commented May 6, 2019

federation push image to quay.io when CI succeed. It pushes images for kubernetes-multicluster/federation-v2 with canary, latest and tag version, e.g. v0.0.9.

@gyliu513
Copy link
Contributor Author

gyliu513 commented May 6, 2019

@xunpan Yes, shall we follow same logic for ibmcloud images?

@xunpan
Copy link
Contributor

xunpan commented May 6, 2019

@gyliu513 I'm trying to understand how to set credential to access quay.io in travis. After that, I will fix this issue.

@gyliu513
Copy link
Contributor Author

gyliu513 commented May 6, 2019

how to set credential to access quay.io

Yes, this is exactly what we should do.

@morvencao
Copy link
Contributor

@xunpan I think we need to put the credential in k8s secret that prow jobs can access.

@jichenjc
Copy link
Contributor

jichenjc commented May 6, 2019

only want to make sure my understanding, we will push the image when
CI passed and merged into master or just CI passed and push to registry for test purpose?
both works for me but I want to make sure I understand the correct way, thank you @morvencao @gyliu513 @xunpan

@xunpan
Copy link
Contributor

xunpan commented May 7, 2019

The logic is pushing image after CI passed for canary image. The code at the moment is not merged yet. CI is prerequisite for merge but not do code merge automatically.

For release versioned and latest (latest release one), they are only push by a tag (for release).

@xunpan
Copy link
Contributor

xunpan commented May 7, 2019

@morvencao I guess it is not for this case to pass credential manually by k8s secret. It is better to set it in security place and follow up existing practise.

@gyliu513 gyliu513 changed the title Always push latest image to quay.io Push latest image to quay.io via CI process May 7, 2019
@xunpan
Copy link
Contributor

xunpan commented May 8, 2019

federation v2 uses travis ci but ibmcloud cluster api uses test-infra.

@xunpan
Copy link
Contributor

xunpan commented May 17, 2019

I think it has no existing ways to push image automatically to cloud and keep security private in test-infra.
- there is no response from sig-testing community in slack
- checked related provider and their settings in test-infra

I'm still thinking is it necessary to make automatically pushed.

  • For end users, they can use released image. We upload it in each release by the script. The lates version seems makes less sense to them.
  • For develpers, they can build their own version by the scripts.

Any comments? @gyliu513

@gyliu513
Copy link
Contributor Author

@xunpan +1 for this, let me close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

5 participants