Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kube-vip spec in cluster templates to adopt k8s 1.29 #1798

Merged
merged 1 commit into from
May 29, 2024

Conversation

Amulyam24
Copy link
Contributor

What this PR does / why we need it:
kube-vip has issues when being used with k8s 1.29. This PR fixes them by

  1. From 1.29, a change has been made to kubeadm to provision a separate Kubeconfig file called super-admin.conf and reducing the admin.conf User's access to the permissions provided by the cluster-admin ClusterRole. It is to be noted that in a multi-cluster setup, the super-admin.conf is only created on the primary control plane node, which runs kubeadm init is failing because kube-vip deployment is hardcoded to use admin.conf but kube-vip requires elevated permissions to access the API server during cluster initialization, which are available only when using the super-admin.conf.
  2. From 1.29, hostAliases do not work as expected. Add a work around to mount the volumes to the kube-vip pod manifest.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1792

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Update kube-vip spec in cluster templates to adopt k8s 1.29

@k8s-ci-robot k8s-ci-robot added area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 24, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 24, 2024
Copy link

netlify bot commented May 24, 2024

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 4dd2ee8
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/66503caaaf4f570008a27224
😎 Deploy Preview https://deploy-preview-1798--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Karthik-K-N Karthik-K-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2024
@Prajyot-Parab
Copy link
Contributor

/lgtm
awaiting approval of @mkumatag

Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be temporary fix, but we need to assess this for log run.

see comment kube-vip/kube-vip#684 (comment) for more information.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amulyam24, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3dacebf into kubernetes-sigs:main May 29, 2024
13 checks passed
@Amulyam24
Copy link
Contributor Author

@mkumatag, should we back port this to release-0.8 branch?

@mkumatag
Copy link
Member

@mkumatag, should we back port this to release-0.8 branch?

I feel not required, we aren't testing that branch aggressively!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kube-vip fails to run with Kubernetes 1.29
5 participants