Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference latest version of CAPO in Makefile #651

Closed
prankul88 opened this issue Oct 15, 2020 · 4 comments · Fixed by #656
Closed

Reference latest version of CAPO in Makefile #651

prankul88 opened this issue Oct 15, 2020 · 4 comments · Fixed by #656
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@prankul88
Copy link
Contributor

/kind bug

What steps did you take and what happened:
[A clear and concise description of what the bug is.]
https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/master/Makefile#L319
make create-cluster command refer to old CAPO version.

What did you expect to happen:
This should be changed to v0.3.1

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Cluster API Provider OpenStack version (Or git rev-parse HEAD if manually built):
  • Cluster-API version:
  • Minikube/KIND version:
  • Kubernetes version (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 15, 2020
@prankul88
Copy link
Contributor Author

/assign

@hidekazuna
Copy link
Contributor

The directory name must follow the semantic versioning: vX.Y.Z.
We are developing master branch so it is OK the name is v9.9.9 for example.

@prankul88
Copy link
Contributor Author

@hidekazuna Sorry I must have missed the conversation.

The directory name must follow the semantic versioning: vX.Y.Z.
We are developing master branch so it is OK the name is v9.9.9 for example.

Ohh okay, got your point. I just saw the PR for the same got merged. Is there something that needs to be changed now?
Thanks for helping

@hidekazuna
Copy link
Contributor

@prankul88 It is ok to be merged 😄 I do not know the best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants