Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module path should be sigs.k8s.io/cluster-api-provider-packet #164

Closed
displague opened this issue Jul 31, 2020 · 1 comment · Fixed by #165
Closed

Module path should be sigs.k8s.io/cluster-api-provider-packet #164

displague opened this issue Jul 31, 2020 · 1 comment · Fixed by #165

Comments

@displague
Copy link
Member

displague commented Jul 31, 2020

When importing this package in other projects, the module path must match the source name.

$ go mod vendor
warning: ignoring symlink /Users/marques/src/openshift-installer/pkg/asset/store/data
go: sigs.k8s.io/cluster-api-provider-packet@v0.1.0: parsing go.mod:
        module declares its path as: github.com/packethost/cluster-api-provider-packet
                but was required as: sigs.k8s.io/cluster-api-provider-packet

The source should be sigs.k8s.io/cluster-api-provider-packet.

Compare

module github.com/packethost/cluster-api-provider-packet

to:

@deitch
Copy link
Contributor

deitch commented Jul 31, 2020

Definitely nice catch. Open a PR @displague ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants