Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider updating or dropping cert-manager image loads in vsphere.yaml #3046

Closed
sbueringer opened this issue Jun 10, 2024 · 4 comments · Fixed by #3060
Closed

Consider updating or dropping cert-manager image loads in vsphere.yaml #3046

sbueringer opened this issue Jun 10, 2024 · 4 comments · Fixed by #3060
Assignees

Comments

@sbueringer
Copy link
Member

sbueringer commented Jun 10, 2024

We should either load the correct images, or just drop them from the file:

  - name: quay.io/jetstack/cert-manager-cainjector:v1.12.2
    loadBehavior: tryLoad
  - name: quay.io/jetstack/cert-manager-webhook:v1.12.2
    loadBehavior: tryLoad
  - name: quay.io/jetstack/cert-manager-controller:v1.12.2
    loadBehavior: tryLoad

I don't know if there is any upside to loading the images in the test-framework instead of just with regular pulls in CAPV

(Definitely no upside in loading the wrong images 😂)

@sbueringer
Copy link
Member Author

@fabriziopandini @chrischdi WDYT?

@chrischdi
Copy link
Member

Let's drop it, as we won't be able to keep it up to date.

@fabriziopandini
Copy link
Member

/assign

@chrischdi
Copy link
Member

We should propably also drop the ones for CAPI or implement the go marker thing for these too:

  - name: registry.k8s.io/cluster-api/cluster-api-controller:v1.7.1
    loadBehavior: tryLoad
  - name: registry.k8s.io/cluster-api/kubeadm-bootstrap-controller:v1.7.1
    loadBehavior: tryLoad
  - name: registry.k8s.io/cluster-api/kubeadm-control-plane-controller:v1.7.1
    loadBehavior: tryLoad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants