Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metadata client does not apply patch options #1507

Closed
furkhat opened this issue May 3, 2021 · 0 comments · Fixed by #1508
Closed

metadata client does not apply patch options #1507

furkhat opened this issue May 3, 2021 · 0 comments · Fixed by #1508

Comments

@furkhat
Copy link
Contributor

furkhat commented May 3, 2021

The opts argument is ignored. I think .ApplyOptions(opts) should be called here https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/client/metadata_client.go#L107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 metadata client applies patch options syseleven/controller-runtime
1 participant
@furkhat