馃悰 pkg/certwatcher: Start should retry for 10s when adding files #2160
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
/assign @sbueringer |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/M
pkg/certwatcher/certwatcher.go
Outdated
| } | ||
| return true, nil | ||
| }); err != nil { | ||
| return errors.Wrapf(kerrors.NewAggregate([]error{err, watchErr}), "failed to add watches") |
There was a problem hiding this comment.
Based on the failed job I assume this would be the first direct use of the errors lib in CR. Intentional?
There was a problem hiding this comment.
Yeah, don't see why not use it, nicer APIs :)
There was a problem hiding this comment.
Just wasn't sure given it was never used before in CR. And also it's unmaintained since a while (https://github.com/pkg/errors)
vincepri
force-pushed
the
fix-certwatcher-flake
branch
2 times, most recently
from
48c0a8e
to
9032bc9
Compare
|
/lgtm /hold |
k8s-ci-robot
added
do-not-merge/hold
This fixes a flake in CI, but it could also come in handy when running the certwatcher against volume mounted certificates. Ideally the timeout is going to be configurable at some point, for now, let's just retry for a fixed number of seconds, before returning an error. Signed-off-by: Vince Prignano <vincepri@redhat.com>
vincepri
force-pushed
the
fix-certwatcher-flake
branch
from
9032bc9
to
ab55747
Compare
k8s-ci-robot
removed
the
lgtm
|
Thx! /lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
This fixes a flake in CI, but it could also come in handy when running the certwatcher against volume mounted certificates. Ideally the timeout is going to be configurable at some point, for now, let's just retry for a fixed number of seconds, before returning an error.
Signed-off-by: Vince Prignano vincepri@redhat.com