New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage for controller startup with conversion #2322

Closed

sbueringer opened this issue May 11, 2023 · 0 comments · Fixed by #2418

Assignees

Member

sbueringer commented May 11, 2023

Let's improve our test coverage as a follow-up to: #2321

The PR description describes the deadlock we encountered in detail. The following describes the test we need to ensure this doesn't happen again.

Create a CRD with apiVersion v1
Create CRs for this apiVersion
Update the CRD to introduce apiVersion v2 (which should be also the new storage version)
Setup a manager which:
- implements conversion for this CRD
- reconciles / watches the CRD
Start the manager and ensure it works without a deadlock

sbueringer self-assigned this

sbueringer mentioned this issue

🌱 Add integration test to avoid manager.Start deadlocks #2418

Merged

k8s-ci-robot closed this as completed in #2418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment