-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We should need an event return #374
Comments
I have the same problem, @mengzn do you want to implement it? |
Could you explain the use case and how you would use this field in your reconciler? |
@shawn-hurley |
To handle the deletion, I believe that you should be using a finalizer. Can you explain how you intend to use the modified data? |
I think that it is not just a deletion. |
You should never be writing reconcilers that differentiate between the different operations. That's bound to get you into trouble. Instead, each reconcile, you should check to see if the state of the world is different from what you expect, and act accordingly. It shouldn't matter if the object was just created or has been updated, what matters is that the state of the world conforms to what's specified in the object. This request is explicitly against the design principles of controller-runtime, so I'm going to close it now. If I'm misunderstanding you, please let me know, and I'll re-open the issue. |
Question
What did you do?
We can get the return of the event etc Create,Delete ...
What did you expect to see?
If we design an action here, we can know the state of the current resource.
What did you see instead? Under which circumstances?
By passing the action through the handler, the user can know the current resource situation.
The text was updated successfully, but these errors were encountered: