Support struct embedding

[skonto]

I am hitting this one:

controller-tools/pkg/crd/schema.go

Line 325 in abcf7d8

ctx.pkg.AddError(loader.ErrFromNode(fmt.Errorf("enountered struct field %q without JSON tag in type %q", field.Name, ctx.info.Name), field.RawField))

(btw there is a typo there s/enountered/encountered)
While my types are valid. They just use struct embedding.

[DirectXMan12]

can you please provide the actual struct that you're using? Embedded fields should be handled fine.

[DirectXMan12]

you'll need to mark the field with json:",inline", though

[skonto]

@DirectXMan12 thanks for the hint. I will try that. The field is this one: https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/blob/2c6e9781be7ba0d13272d21a28cc850806f5f39d/pkg/apis/sparkoperator.k8s.io/v1beta1/types.go#L409.

[DirectXMan12]

yeah, that just needs the tag

[skonto]

@DirectXMan12 feel free to close it. It worked thanks!