Do not display help when deleting all pods/containers #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
size/S
k8s-ci-robot
added
size/M
champtar
force-pushed
the
fix-empty-rm
branch
3 times, most recently
from
cda696a
to
33f097a
Compare
k8s-ci-robot
added
size/L
champtar
force-pushed
the
fix-empty-rm
branch
2 times, most recently
from
e39441a
to
c35a217
Compare
|
@SergeyKanzhelev CI is good now, tell me if the tests changes are too intrusive |
Running `crictl rmp -a` or `crictl rm -a` with nothing to delete was displaying the help text instead of saying that there was nothing to delete. Signed-off-by: Etienne Champetier <e.champetier@ateme.com>
'crictl rmi' can take multiple IMAGE-ID, -a and/or -p If we pass nothing, display help text Signed-off-by: Etienne Champetier <e.champetier@ateme.com>
This is a generic version of the CrictlExpect* allowing tests such as Exit(0), empty stdout, specific stderr.
Signed-off-by: Etienne Champetier <e.champetier@ateme.com>
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: champtar, saschagrunert, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Running
crictl rmp -aorcrictl rm -awith nothing to delete was displaying the help text instead of saying that there was nothing to delete.Which issue(s) this PR fixes:
Fixes #1144
Special notes for your reviewer:
Does this PR introduce a user-facing change?