Switch to ginkgo/v2 #910
Merged
Switch to ginkgo/v2 #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
saschagrunert
force-pushed
the
ginkgo-v2
branch
6 times, most recently
from
c360232
to
218925e
Compare
saschagrunert
force-pushed
the
ginkgo-v2
branch
2 times, most recently
from
b7789c3
to
073ce43
Compare
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
|
@feiskyer PTAL |
|
FYI... containerd/containerd#6894 Note the comment that critest --ginkgo.focus="HostIpc" --ginkgo.skip="HostIpc is true" works but add --parallel=2 and it fails to focus or skip.. |
k8s-ci-robot
added
the
lgtm
aznashwan
added a commit
to aznashwan/containerd
that referenced
this pull request
May 9, 2022
Following kubernetes-sigs/cri-tools#910 the Ginkgo reporters are left configured with default settings and thus do not generate a JUnit report file unless we explicitly pass a path for the outfile in the Windows workflow when calling critest.exe. Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Ginkgo v2 has been released since a while and we should upgrade to the new dependency.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?