Use a fake client when evicting pods by individual strategies to accumulate the evictions #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
the
approved
ingvagabund
added a commit
to ingvagabund/cluster-kube-descheduler-operator
that referenced
this pull request
Dec 15, 2021
With kubernetes-sigs/descheduler#677 it is possible to publish descheduler metrics even when running with --dry-run. Thus, also sharing the "what the descheduler would evict" with various configurations. Allowing a user to see effect of the current configuration without touching the cluster.
ingvagabund
force-pushed
the
accumulated-eviction
branch
2 times, most recently
from
14a71e2
to
14764e1
Compare
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
ingvagabund
added a commit
to ingvagabund/cluster-kube-descheduler-operator
that referenced
this pull request
Dec 15, 2021
With kubernetes-sigs/descheduler#677 it is possible to publish descheduler metrics even when running with --dry-run. Thus, also sharing the "what the descheduler would evict" with various configurations. Allowing a user to see effect of the current configuration without touching the cluster.
ingvagabund
force-pushed
the
accumulated-eviction
branch
from
14764e1
to
33ecd57
Compare
k8s-ci-robot
added
needs-rebase
k8s-ci-robot
added
the
needs-rebase
ingvagabund
force-pushed
the
accumulated-eviction
branch
from
33ecd57
to
6c17c8f
Compare
k8s-ci-robot
removed
the
needs-rebase
ingvagabund
force-pushed
the
accumulated-eviction
branch
from
6c17c8f
to
1567ac7
Compare
| @@ -74,6 +75,7 @@ func NewPodEvictor( | |||
| evictSystemCriticalPods bool, | |||
| ignorePvcPods bool, | |||
| evictFailedBarePods bool, | |||
| metricsEnabled bool, | |||
There was a problem hiding this comment.
To avoid accumulating the metrics in case the metrics server is not enabled. To save some instructions.
There was a problem hiding this comment.
How is this related to current change?
| namespaceInformer corev1informers.NamespaceInformer, | ||
| priorityClassInformer schedulingv1informers.PriorityClassInformer, | ||
| ) (clientset.Interface, error) { | ||
| fakeClient := fakeclientset.NewSimpleClientset() |
There was a problem hiding this comment.
Do we need fakeClient, can't we get away with a local cache of pods just like we do in case of scheduler?
There was a problem hiding this comment.
I used the fake client so the strategies can stay unchanged. Replacing one client for another. Creating a local cache of pods would require more changes. Perhaps I don't see the full picture. Would you mind describing the approach in more detail? How a strategy is expected to consume the local cache?
|
@lixiang233 @seanmalloy PTAL |
…mulate the evictions Currently, when the descheduler is running with the --dry-run on, no strategy actually evicts a pod so every strategy always starts with a complete list of pods. E.g. when the PodLifeTime strategy evicts few pods, the RemoveDuplicatePods strategy still takes into account even the pods eliminated by the PodLifeTime strategy. Which does not correspond to the real case scenarios as the same pod can be evicted multiple times. Instead, use a fake client and evict/delete the pods from its cache so the strategies evict each pod at most once as it would be normally done in a real cluster.
ingvagabund
force-pushed
the
accumulated-eviction
branch
from
1567ac7
to
901a16e
Compare
ravisantoshgudimetla
approved these changes
Jan 20, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund, ravisantoshgudimetla The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
ingvagabund
added a commit
to ingvagabund/cluster-kube-descheduler-operator
that referenced
this pull request
Jan 20, 2022
With kubernetes-sigs/descheduler#677 it is possible to publish descheduler metrics even when running with --dry-run. Thus, also sharing the "what the descheduler would evict" with various configurations. Allowing a user to see effect of the current configuration without touching the cluster.
ingvagabund
added a commit
to ingvagabund/cluster-kube-descheduler-operator
that referenced
this pull request
Jan 20, 2022
With kubernetes-sigs/descheduler#677 it is possible to publish descheduler metrics even when running with --dry-run. Thus, also sharing the "what the descheduler would evict" with various configurations. Allowing a user to see effect of the current configuration without touching the cluster.
ingvagabund
added a commit
to ingvagabund/cluster-kube-descheduler-operator
that referenced
this pull request
Jan 24, 2022
With kubernetes-sigs/descheduler#677 it is possible to publish descheduler metrics even when running with --dry-run. Thus, also sharing the "what the descheduler would evict" with various configurations. Allowing a user to see effect of the current configuration without touching the cluster.
briend
pushed a commit
to briend/descheduler
that referenced
this pull request
Feb 11, 2022
…viction Use a fake client when evicting pods by individual strategies to accumulate the evictions
ingvagabund
added a commit
to ingvagabund/cluster-kube-descheduler-operator
that referenced
this pull request
Apr 26, 2022
With kubernetes-sigs/descheduler#677 it is possible to publish descheduler metrics even when running with --dry-run. Thus, also sharing the "what the descheduler would evict" with various configurations. Allowing a user to see effect of the current configuration without touching the cluster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when the descheduler is running with the --dry-run on, no strategy actually evicts a pod so every strategy always starts with a complete list of pods. E.g. when the PodLifeTime strategy evicts few pods, the RemoveDuplicatePods strategy still takes into account even the pods eliminated by the PodLifeTime strategy. Which does not correspond to the real case scenarios as the same pod can be evicted multiple times. Instead, use a fake client and evict/delete the pods from its cache so the strategies evict each pod at most once as it would be normally done in a real cluster.