New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BackendTLSPolicy: Add CEL Tests #2473

Closed

robscott opened this issue Oct 11, 2023 · 1 comment · Fixed by #2491

Labels

kind/cleanup kind/test

Milestone

Member

robscott commented Oct 11, 2023

What would you like to be added:
Tests to ensure the CEL validation added in #2448 is working as expected.

Why this is needed:
All other CEL validations have corresponding go tests in https://github.com/kubernetes-sigs/gateway-api/tree/main/pkg/test/cel. Without it, it's awfully hard to ensure that the CEL we've written covers all the inputs we want to allow or prevent.

robscott added kind/cleanup kind/test labels

robscott mentioned this issue

Update GEP-713 and add BackendTLSPolicy implementation #2448

Merged

Contributor

Ygnas commented Oct 12, 2023 •

edited

I'm going to look into it, as I believe I have hit a problem with the rules

shaneutt added this to the v1.0.0 milestone

Ygnas mentioned this issue

BackendTLSPolicy cel tests #2491

Merged

k8s-ci-robot closed this as completed in #2491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment