Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a github action to create a kind cluster and run some tests #16

Closed
dims opened this issue Dec 20, 2023 · 7 comments
Closed

Add a github action to create a kind cluster and run some tests #16

dims opened this issue Dec 20, 2023 · 7 comments

Comments

@dims
Copy link
Member

dims commented Dec 20, 2023

  • Run a single test (quick!)
  • Run conformance tests.
@rjsadow
Copy link
Collaborator

rjsadow commented Dec 21, 2023

@dims for Run conformance tests. what are you envisioning? Running the entire conformance suite?

@dims
Copy link
Member Author

dims commented Dec 21, 2023

@rjsadow not on every PR, but periodically

@dims
Copy link
Member Author

dims commented Dec 21, 2023

using --focus='[Conformance]' should be enough

@rjsadow
Copy link
Collaborator

rjsadow commented Dec 21, 2023

Periodic test is running (https://github.com/dims/hydrophone/actions/runs/7284630106), however it does exit with a successful return code. I'm gathering that hydrophone is running the test, reporting on the logs of the pod, then exits successfully. This will make any CI tests difficult to determine if there are failures. @dims how do you feel about tying the exit code of hydrophone with the exit code of the pod?

@dims
Copy link
Member Author

dims commented Dec 21, 2023

sounds good @rjsadow

@rjsadow
Copy link
Collaborator

rjsadow commented Dec 21, 2023

#28 didn't work as expected. I'll look into more how we can ensure we bubble up the test status

https://github.com/dims/hydrophone/actions/runs/7287900898/job/19859462277#step:8:37974

@dims
Copy link
Member Author

dims commented Dec 22, 2023

let's open up fresh issues as we see these @rjsadow - i have some changes in there which should help.

@dims dims closed this as completed Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants