-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a github action to create a kind cluster and run some tests #16
Comments
@dims for |
@rjsadow not on every PR, but periodically |
using |
Periodic test is running (https://github.com/dims/hydrophone/actions/runs/7284630106), however it does exit with a successful return code. I'm gathering that hydrophone is running the test, reporting on the logs of the pod, then exits successfully. This will make any CI tests difficult to determine if there are failures. @dims how do you feel about tying the exit code of hydrophone with the exit code of the pod? |
sounds good @rjsadow |
#28 didn't work as expected. I'll look into more how we can ensure we bubble up the test status https://github.com/dims/hydrophone/actions/runs/7287900898/job/19859462277#step:8:37974 |
let's open up fresh issues as we see these @rjsadow - i have some changes in there which should help. |
The text was updated successfully, but these errors were encountered: