Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to move KB declarative pattern to an external plugin #293

Open
varshaprasad96 opened this issue Jan 14, 2023 · 7 comments · May be fixed by #300
Open

Proposal to move KB declarative pattern to an external plugin #293

varshaprasad96 opened this issue Jan 14, 2023 · 7 comments · May be fixed by #300
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@varshaprasad96
Copy link
Member

What would you like to be added:
This is a follow up based on the conversation in #291 (comment). With the introduction of Phase 2 (out-of-tree external plugins) in Kubebuilder, we now have the flexibility to extend Kubebuilder and build/release any plugin independently outside the KB project. This paves way for smoother version upgrades across projects and eases the maintenance effort.

Given this, we would like to know if we can go ahead with moving the Kubebuilder-declarative-pattern out of Kubebuilder, and building an external plugin for the same. The immediate benefits of this are:

  • KB release need not be blocked on KB-declarative-pattern to upgrade dependencies during every K8s release cycle.
  • The maintenance and release of KB-declarative-plugin can be handled independently, instead of relying on KB.

This would decouple the inter-dependency of both the projects.

@varshaprasad96 varshaprasad96 added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 14, 2023
@varshaprasad96
Copy link
Member Author

cc: @camilamacedo86

@varshaprasad96 varshaprasad96 changed the title Proposal on moving KB declarative pattern to external plugin Proposal to move KB declarative pattern to an external plugin Jan 14, 2023
@justinsb
Copy link
Contributor

As discussed in controller-runtime office hours, this sounds like a good move for both projects - it's exciting that external plugins are now supported. If anyone wants to work on this they are very welcome to - please just comment here. Otherwise I'll likely tackle it if/when I find time!

@camilamacedo86 camilamacedo86 added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jan 26, 2023
@em-r
Copy link

em-r commented Jan 27, 2023

@justinsb I'm interested in working on this, however, I'm still new to the declarative pattern, would that be okay?

@justinsb
Copy link
Contributor

Of course @em-r - any help would be greatly appreciated. I'm not familiar with the external plugin architecture, but maybe between us we can figure it out :-)

A good way to proceed might be to try copying the plugin code into this repository, and seeing what breaks, and maybe send a WIP PR to enable collaboration and discussion if there's any issues. But happy to work however best suits you!

@em-r
Copy link

em-r commented Jan 27, 2023

Thank you @justinsb
Indeed, a WIP PR is definitely a good way to move forward, I'll go ahead and assign the ticket to myself, and send a WIP PR once I copy the plugin code to this repository.

/assign

@em-r em-r linked a pull request Jan 29, 2023 that will close this issue
4 tasks
@camilamacedo86
Copy link
Member

camilamacedo86 commented Feb 9, 2023

Hi @em-r,

@rashmigottipati and @brycecr are those that who worked out mostly in the plugin phase 2 (external plugins API) code implementation. Also, feel free to ping in the kubebuilder channel and raise questions or issues. We will try to help us much as possible. If we do not know something we can find out :-)

Thank you for looking on that. That is a terrific nice project/initiative that will help a lot !!!

@em-r
Copy link

em-r commented Feb 9, 2023

@camilamacedo86 - sounds great, I'll definitely reach out in kubebuilder channel, thank you for the support!

@camilamacedo86 camilamacedo86 added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. labels May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants