Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action scope #11

Closed
Adirio opened this issue Nov 6, 2020 · 2 comments · Fixed by #12
Closed

Action scope #11

Adirio opened this issue Nov 6, 2020 · 2 comments · Fixed by #12

Comments

@Adirio
Copy link
Contributor

Adirio commented Nov 6, 2020

Actions submit CheckRuns for different checks. Those CheckRuns owned by a commit, not by a PR. Therefore, when a new commit gets (force-)pushed, the CheckRuns that reports the result of this action is lost.

Could we retrieve the previous CheckRuns from the old commit on: pull-request: [synchronize] and push them to the new commit? I think the hard part here will be knowing the sha of the commit that holded the previous checks.

In this case the pseudo code would be:

on: pull-request: open
- create CheckRun with "in_progress" status
- perform the checks
- update CheckRun with results

on: pull-request: edit
- update CheckRun with "in_progress" status
- perform the checks
- update CheckRun with results

on: pull-request: synchronize
- find the previous commit hash
- create CheckRun with same result as CheckRun @ previous commit
@Adirio
Copy link
Contributor Author

Adirio commented Nov 6, 2020

/cc @DirectXMan12 @vincepri

@DirectXMan12
Copy link
Contributor

yep, we need synchronize. I think it's probably fine to just re-run the run on synchronize though -- it's not too expensive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants