Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

Replica count of federated deployment is not updated by RSP plugin #1087

Closed
sancyx opened this issue Aug 7, 2019 · 0 comments · Fixed by #1089
Closed

Replica count of federated deployment is not updated by RSP plugin #1087

sancyx opened this issue Aug 7, 2019 · 0 comments · Fixed by #1089
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@sancyx
Copy link
Contributor

sancyx commented Aug 7, 2019

What happened:
After creating a ReplicaSchedulingPreference targeting a FederatedDeployment, cluster overrides for spec.replicas field of FederatedDeployment are not updated. I can see in debug log of ReplicaScheduler that replica counts are calculated correctly however FederatedDeployment is not updated.

What you expected to happen:
FederatedDeployment is updated with latest overrides per cluster.

How to reproduce it (as minimally and precisely as possible):
Create a ReplicaSchedulingPreference targeting a FederatedDeployment.

Anything else we need to know?:
It seems that the problem is in schedulingtypes.updateOverridesMap function, where overrides in the map are only updated locally in stack.

Environment:

  • Kubernetes version: v1.14.2
  • KubeFed version: v0.1.0-rc5
  • Scope of installation: cluster

/kind bug

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants