Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Oracle Linux #3655

Merged
merged 1 commit into from Jul 12, 2019
Merged

Add support for Oracle Linux #3655

merged 1 commit into from Jul 12, 2019

Conversation

jbornemann
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 6, 2018
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 6, 2018
@jbornemann
Copy link
Contributor Author

We should probably add this to the test matrix? Should we add oracle linux 7 to GCE?

@jbornemann jbornemann force-pushed the upstream_oel_support branch 2 times, most recently from 0744fa7 to 3f37e1c Compare November 6, 2018 18:54
@ant31
Copy link
Contributor

ant31 commented Nov 8, 2018 •
edited

Yes, please add it in the test matrix as a manual job, aio + kubeadm.

@mirwan mirwan mentioned this pull request Nov 12, 2018
Closed
@woopstar
Copy link
Member

Please resolve conflicts

mirwan
mirwan suggested changes Nov 20, 2018
View reviewed changes
roles/kubernetes/preinstall/defaults/main.yml Outdated
@@ -8,7 +8,6 @@ epel_enabled: false
dns_late: false

common_required_pkgs:
- python-httplib2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If python-httplib2 is to be removed from here it should be added to the per-distrib vars in roles/kubernetes/preinstall/vars for each other distrib

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

roles/bootstrap-os/tasks/main.yml Outdated
@@ -73,3 +78,6 @@
filter: ansible_hostname
when:
- hostname_changed.changed

- name: Install httplib2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installation of httplib2 is done via system packages for all but coreos distribs so this task should be removed from here and added to bootstrap-oracle.yml instead (in the same way as it is done for coreos maybe)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed. Thanks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still an issue here. There is no need to install httplib2 via pip on every distrib especially if some of them provide a system package for it (i.e. ubuntu)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an outdated diff. This has already been changed.

roles/bootstrap-os/tasks/bootstrap-opensuse.yml Outdated Show resolved Hide resolved
roles/bootstrap-os/tasks/bootstrap-fedora.yml Outdated Show resolved Hide resolved
roles/bootstrap-os/defaults/main.yml Outdated Show resolved Hide resolved
@mirwan
Copy link
Contributor

mirwan commented Dec 3, 2018

ci check this

@jbornemann
Copy link
Contributor Author

The Oracle 7 image will need to be added to GCE and named under the oracle-7 family for CI to be effective.
per :
#3655 (comment)

I'd be happy to do it if I'm given credentials.

@jbornemann
Copy link
Contributor Author

Hi @mirwan @ant31 anything I can do to move this along?

I just rebased, and fixed some conflicts.

@mirwan
Copy link
Contributor

mirwan commented Dec 18, 2018

@jbornemann Thx for the rebase and fix. I don't have the credentials (and never used GCE before, but I could give it a try if need be) so I guess @ant31 is needed here

@jbornemann
Copy link
Contributor Author

Cool. Let me know if there is anything I can do to help. I'll just leave this here so that it doesn't get lost in the sea of comments :

I've got an Oracle 7.5 image packaged, and GCE ready here:

https://storage.googleapis.com/born-images/oracle75/compressed-image.tar.gz

Does this project have storage available in Google Storage? If so, it can be copied there, then referenced when creating a new image @

https://console.cloud.google.com/compute/imagesAdd?project=

Set family name to oracle-7, and we should be good to go.

@jbornemann
Copy link
Contributor Author

Hey @mattymo would you mind helping with putting the above image into GCE/storage so we can get this in?

@jbornemann jbornemann mentioned this pull request Jan 10, 2019
Closed
@jbornemann
Copy link
Contributor Author

Fixed merge conflicts from upstream changes.

@mirwan if you think this looks good, it would be great to get this in

@Atoms
Copy link
Member

Atoms commented Jan 10, 2019

/hold

Please wait till new ci is merged

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2019
@Miouge1
Copy link
Contributor

Miouge1 commented Feb 7, 2019

Waiting for #4005

@amcirillo
Copy link

What's the status on this? I recently had need to deploy kubernetes to oracle linux and found that kubespray didn't work properly. So I fixed the problems and have a commit that adds support for oracle linux. I can submit a new PR if this effort has died. I would like to see this make it into the project.

@k8s-ci-robot k8s-ci-robot requested review from woopstar and removed request for Miouge1 and ant31 June 5, 2019 13:59
@jbornemann
Copy link
Contributor Author

/assign @jbornemann

@jbornemann
Copy link
Contributor Author

packet related provisioning errors. may need to run again

@woopstar
Copy link
Member

woopstar commented Jun 6, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbornemann, woopstar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2019
@jbornemann
Copy link
Contributor Author

/lgtm

@k8s-ci-robot
Copy link
Contributor

@jbornemann: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jbornemann
Copy link
Contributor Author

opps.

@woopstar this seems to be stuck in a weird CI state. It shows that you are pending approval, even though you just approved. Who can lgtm?

@woopstar
Copy link
Member

woopstar commented Jun 6, 2019

Well. It did not pass the packet_oracle-7-canal job:

https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/226463409

So I cannot lgtm yet.

@jbornemann jbornemann force-pushed the upstream_oel_support branch 2 times, most recently from 1ca9adc to f8a2aef Compare June 18, 2019 16:25
@jbornemann
Copy link
Contributor Author

@woopstar I had some time to look at this, and I think I figured out what was happening. The test OL image was running an old kernel that did not have pid cgroup support, so it was running into issues with our test group_vars configuration. We didn't see this issue internally, because we have been running an older version of k8s.

I updated the kernel on the test image, and reuploaded the updated qcow2. Could you help run the test-infra to get that where it needs to be?

@jbornemann
Copy link
Contributor Author

@Miouge1 hey would you mind helping with the image again?

@jbornemann
Copy link
Contributor Author

bump

@ant32
Copy link

ant32 commented Jul 10, 2019 via email

Support for Oracle Linux
1cc1616 
Fixed Issue kubernetes-sigs#1032

test case for OEL7 AIL with kubeadm

Add packet CI stuff for oracle 7
@jbornemann
Copy link
Contributor Author

@woopstar for approval

@woopstar
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit 728155a into kubernetes-sigs:master Jul 12, 2019
@jbornemann jbornemann deleted the upstream_oel_support branch July 22, 2019 17:39
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Aug 4, 2019
@LuckySB
Support for Oracle Linux (kubernetes-sigs#3655)
1459aa0 
Fixed Issue kubernetes-sigs#1032

test case for OEL7 AIL with kubeadm

Add packet CI stuff for oracle 7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkusTeufelberger MarkusTeufelberger MarkusTeufelberger left review comments

@ant31 ant31 ant31 left review comments

@Miouge1 Miouge1 Miouge1 left review comments

@koriukiv koriukiv koriukiv left review comments

@mirwan mirwan mirwan approved these changes

@woopstar woopstar Awaiting requested review from woopstar

Assignees

@woopstar woopstar

@jbornemann jbornemann

@Miouge1 Miouge1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
2.11
Development

Successfully merging this pull request may close these issues.

None yet