CNI: Weave tolerations do not support "NoExecute" effects

[fydrah]

Hi,

Environment:

• Cloud provider or hardware configuration: N/A

• OS (printf "$(uname -srm)\n$(cat /etc/os-release)\n"): N/A

• Version of Ansible (ansible --version): N/A

• Version of Python (python --version): N/A

Kubespray version (commit) (git rev-parse --short HEAD): 437189c2

Network plugin used: weave

Full inventory with variables (ansible -i inventory/sample/inventory.ini all -m debug -a "var=hostvars[inventory_hostname]"): N/A

kube_network_plugin: weave

Command used to invoke ansible:

ansible-playbook -i $INVENTORY cluster.yml

Output of ansible run: N/A

Anything else do we need to know:

If nodes have taints with NoExecute effect, weave DaemonSet is not configured to be deployed on them.

• The following PR changed all CNI manifests to support any toleration effects
• But this PR overwrites toleration changes

Weave network plugin manifest should be configured to support any effects.

# roles/network_plugin/weave/templates/weave-net.yml.j2#226
[...]
          tolerations:
            - operator: Exists
            # Mark pod as critical for rescheduling (Will have no effect starting with kubernetes 1.12)
            - key: CriticalAddonsOnly
              operator: "Exists"
[...]

I will push the associated patch soon.