Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kube-master kubelet config #687

Closed
mattymo opened this issue Dec 7, 2016 · 5 comments
Closed

Update kube-master kubelet config #687

mattymo opened this issue Dec 7, 2016 · 5 comments
Labels
compat kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@mattymo
Copy link
Contributor

mattymo commented Dec 7, 2016

If kube-master node is not in kube-node group, it needs to ensure the following options are not present:
--apiserver
--kubeconfig
--require-kubeconfig
--register-node
--register-unschedulable

This is in reference to discussion in issue kubernetes/kubernetes#38187 (comment)

@codablock
Copy link
Contributor

As discussed on Slack, I'd prefer to have the masters as part of cluster, but being unschedulable. This gives the advantage that you can use kubectl to analyze the cluster state. To implement this, we have 2 options:

  1. Use --register-node=true (or omit it completely) + --register-unschedulable=false
  2. Use UnSchedulable taints on the master node

kubeadm already does solution 2. and I'd actually prefer this as it gives admins the ability to force schedule stuff on masters with tolerations.

There is however one problem with this: DaemonSets completely ignore taints and the unschedulable flag atm (v1.5.0-beta.2). This means they are scheduled on all registered nodes, including the masters. Honoring taints was once merged into kubernetes but then later reverted in kubernetes/kubernetes#31907. Not sure when it will be unreverted.

We can probably ignore this for now and still use the unschedulable flag or taints. I would assume that most users only use DaemonSets for cluster wide admin stuff, like logging addons. In this case it would be ok and probably even desired. Also, DaemonSets seem to be still in Beta, so maybe we can accept some unexpected behavior here.

@bogdando bogdando added compat kind/bug Categorizes issue or PR as related to a bug. labels Dec 7, 2016
@bogdando
Copy link
Contributor

We have two independent reproduces of the blocking issue for coreos-stable: static pods are missing on the env while conf files for them are in place

@bogdando
Copy link
Contributor

Let's first remove the blocking factor, then think of a proper implementation

@bogdando
Copy link
Contributor

Related #737

@bogdando
Copy link
Contributor

bogdando commented Dec 14, 2016

Could we now try to address the restarting static pods issue described here #737 (comment) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compat kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

3 participants