Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Events may show events from prior versions of resource #8977

Closed
starpit opened this issue Aug 20, 2022 · 2 comments · Fixed by #9001 or #9006
Closed

Show Events may show events from prior versions of resource #8977

starpit opened this issue Aug 20, 2022 · 2 comments · Fixed by #9001 or #9006
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@starpit
Copy link
Contributor

starpit commented Aug 20, 2022 •
edited
Loading

We currently show events for prior versions/instances of the given resource. I think we can add involvedObject.uid to the "Show Events" drilldown query

edit: involvedObject.resourceVersion not uid
@starpit starpit added the kind/bug Categorizes issue or PR as related to a bug. label Aug 20, 2022
@starpit starpit changed the title kubectl events drilldown from sidecar needs to use resource uid kubectl events drilldown from sidecar may show events from prior versions of the given resource Aug 20, 2022
@starpit starpit changed the title kubectl events drilldown from sidecar may show events from prior versions of the given resource kubectl Show Events may show events from prior versions of the given resource Aug 20, 2022
@starpit starpit changed the title kubectl Show Events may show events from prior versions of the given resource kubectl Show Events may show events from prior versions of resource Aug 20, 2022
@starpit starpit changed the title kubectl Show Events may show events from prior versions of resource Show Events may show events from prior versions of resource Aug 20, 2022
@starpit
Copy link
Contributor Author

starpit commented Aug 20, 2022 •
edited
Loading

I think the same is true for the events shown in the kubectl apply table footer.

@starpit starpit mentioned this issue Sep 3, 2022
Merged
7 tasks
@starpit
Copy link
Contributor Author

starpit commented Sep 3, 2022

Oof, for some reason, the resourceVersion of events ... i just don't understand it. It does not correspond to the latest version of the resource. So there must be some intermediate versions to which the event applied.

In any case, using resourceVersion as a join key for the events query will not work. We indeed need to use the uid

@starpit starpit reopened this Sep 3, 2022
@starpit starpit mentioned this issue Sep 3, 2022
Merged
7 tasks
@starpit starpit closed this as completed Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
1 participant
@starpit