-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Easy way to update the container image name #109
Comments
Maybe this could mostly be accomplished by allowing the name field to be a regular expression? |
The idea in #122 can help this. If kustomize provides to way to declare a user defined transformation and use that, this transformation can will be applied during |
I love this idea/feature as well. I work on mono-repo project where we manage kubernetes spec for 30 microservice. We have templated everything in spec so that adding new service is a breeze. Templating logic is so complicated we have decided to move away from that approach and start evaluating tools like Kompose. Kompose doesn't fit for the project structure as the selector for deployment works by metadata->name and I will end up overlays for each service and lots of duplication |
Does seem to make sense to be able to target resources with something other than name, label perhaps. The README relates kustomize to sed |
Regardless of the patches or transformation. The original request is to ask an easy way to update the container image name wherever it is used. |
@Liujingfang1 actually, I was concerned about transforming/sharing multiple pod values, not just the container name. |
@bickfordb What pod values you need to update? Can you give an example? |
I think there are 2 issues here:
|
This can be solved by #122
This is supported by |
@Liujingfang1 are you particularly opposed to allowing patches to match on a label based selector? |
The link is dead: |
@bickfordb This issue was closed because of it's name and the introduction of set imageTag command. The notion of applying patches guided by a label based selection could certainly be opened as a new issue. As could the If you have time, please look at the conversation in #300 (less so the one in #169) and feel free to comment. It's closely related so some of what you mentioned above w/r (outside the scope of changing only the image tag). |
👍 |
In order to reduce copy and paste in large applications, it would be nice to be able to patch multiple resources with one patch via some kind of selector other than name. For instance, in my Kubernetes application, I have separate web and job pods that share the same Docker image, most of the same pod values which I need to copy and paste into each. If one could write a patch that matched on a label or some other kind of selector, these shared values could be factored out.
The text was updated successfully, but these errors were encountered: