Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo: kubectl v1.15 -> kubectl v1.14 #1333

Merged
merged 4 commits into from
Jul 12, 2019

Conversation

gosharplite
Copy link
Contributor

Match version number to the version in the link.

Match version number to the version in the link.
@k8s-ci-robot
Copy link
Contributor

Welcome @gosharplite!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gosharplite
To complete the pull request process, please assign liujingfang1
You can assign the PR to them by writing /assign @liujingfang1 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 10, 2019
@gosharplite
Copy link
Contributor Author

/assign @Liujingfang1

@Liujingfang1
Copy link
Contributor

kustomize 2.0.3 is available in kubectl 1.14 and 1.15. Can you add both of them? Thank you

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 11, 2019
@gosharplite
Copy link
Contributor Author

Yes, I have put both v1.14 and v1.15 into this PR.

I originally thought K8s v1.15 release note should announce it uses kustomize v2.0.3, then I tried $kubectl kustomize version, but it doesn't work.

It seems this PR will become the only place a user can get the relationship between kubectl kustomize and kustomize in a straight forward way.

Is there other work in progress that will let a user find this info easier?

@gosharplite
Copy link
Contributor Author

I have amended my commit with correct email address.
Hopefully the cncf-cla flag will be cleared.

@tonyhsu2019
Copy link

I have also signed the CLA with this account tonyhsu2019.
Let's see if this will clear the cncf-cla.

@Liujingfang1
Copy link
Contributor

/retest

@Liujingfang1 Liujingfang1 merged commit 0edab60 into kubernetes-sigs:master Jul 12, 2019
richardmarshall pushed a commit to richardmarshall/kustomize that referenced this pull request Aug 13, 2019
* Fix typo: kubectl v1.15 -> kubectl v1.14

Match version number to the version in the link.

* Add both kubectl v1.14 and v1.15

* Add both kubectl v1.14 and v1.15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants