Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mounting volumes into functions #1902

Closed
pwittrock opened this issue Dec 6, 2019 · 4 comments
Closed

Support mounting volumes into functions #1902

pwittrock opened this issue Dec 6, 2019 · 4 comments
Assignees
Labels
area/kyaml issues for kyaml good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Comments

@pwittrock
Copy link
Contributor

Context: kustomize config run

Functions should be able to request access to the network in the Resource metadata.

e.g.

apiVersion: v1beta1
kind: Foo
metadata:
  name: foo
  configFn:
    container:
      image: gcr.io/kustomize-functions/example-tshirt:v0.1.0
      volumes:
      - src: path-to-src
         dest: path-to-dest
  • if a function specifies configFn.container.volumes the local volumes should be mounted into the functions contain
  • volumes must be in a directory under the config directory (no ../)
  • volumes are relative to the Resource config

Files to change

  • kyaml/runfn/runfn.go:
    • In init -- have the containerFilterProvider function check if the container requires volumes
    • Validate the volumes are not above the function config resource
    • Use the path annotation on the function Resource to get its location
    • Mount volumes relative to the Resource
@pwittrock pwittrock added this to Needs triage in Backlog (pwittrock will review) via automation Dec 6, 2019
@pwittrock pwittrock added area/kyaml issues for kyaml good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 6, 2019
@pwittrock pwittrock moved this from Needs triage to Low priority in Backlog (pwittrock will review) Dec 6, 2019
@bzub
Copy link
Member

bzub commented Dec 12, 2019

Does this replace #1839 ?

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 11, 2020
@prachirp
Copy link
Contributor

prachirp commented Apr 2, 2020

/assign @prachirp

@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 2, 2020
Backlog (pwittrock will review) automation moved this from Backlog to Closed May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kyaml issues for kyaml good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
No open projects
Development

No branches or pull requests

5 participants