patchesJson6902 with operation "move" fail under certain circumstances.

[sanposhiho]

Hi :)

Describe the bug

• use patchesJson6902 with operation move
• move /metadata/name
• patchesJson6902 has several targets
• several targets has same group, target, and kind

When use the above resource from other kustomization.yaml with resources statements, the following errors occur

Error: accumulating resources: accumulateFile "accumulating resources from '../jobs/': '~/workspace/sample/jobs' must resolve to a file", accumulateDirector: "recursed merging from path '~/workspace/sample/jobs': may not add resource with an already registered id: batch_v1_Job|~X|~N"

Files that can reproduce the issue

https://github.com/sanposhiho/kustomize-jsonpatches-bug-sample

$ kustomize build jobs/
apiVersion: batch/v1
kind: Job
metadata:
  generateName: hogehoge
spec:
  template:
    spec:
      containers:
      - image: hoge:latest
        name: hogehoge
---
apiVersion: batch/v1
kind: Job
metadata:
  generateName: fugafuga
spec:
  template:
    spec:
      containers:
      - image: fuga:latest
        name: fugafuga

$ kustomize build api
Error: accumulating resources: accumulateFile "accumulating resources from '../jobs/': '~/workspace/sample/jobs' must resolve to a file", accumulateDirector: "recursed merging from path '~/workspace/sample/jobs': may not add resource with an already registered id: batch_v1_Job|~X|~N"

Expected output

$ kustomize build api/
apiVersion: batch/v1
kind: Job
metadata:
  generateName: hogehoge
spec:
  template:
    spec:
      containers:
      - image: hoge:latest
        name: hogehoge
---
apiVersion: batch/v1
kind: Job
metadata:
  generateName: fugafuga
spec:
  template:
    spec:
      containers:
      - image: fuga:latest
        name: fugafuga

Actual output

$ kustomize build api
Error: accumulating resources: accumulateFile "accumulating resources from '../jobs/': '~/workspace/sample/jobs' must resolve to a file", accumulateDirector: "recursed merging from path '~/workspace/sample/jobs': may not add resource with an already registered id: batch_v1_Job|~X|~N"

Kustomize version

$ kustomize version
{Version:kustomize/v3.8.5 GitCommit:4052cd4fd8c76a17b5f64e32509f3fba9713fe75 BuildDate:2020-10-08T05:35:40+01:00 GoOs:darwin GoArch:amd64}

Platform

macOS

[Shell32-Natsu]

I cannot reproduce this issue. Looks like you should update the paths you used in the patch. Since you have a / in the field name so you need to replace it by ~1 in json patch path.

[sanposhiho]

Sorry, I forgot to commit my latest sample.
Please check again as I've updated the sample.

[Shell32-Natsu]

After your json patch, 2 resources don't have /metadata/name field. And in the overlay, these 2 resources are needed to be added to the resource list. This causes problem, because these 2 resources now have identical ID batch_v1_Job|~X|~N.