Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add YAML anchor/alias expansion. #4114

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Add YAML anchor/alias expansion. #4114

merged 1 commit into from
Aug 24, 2021

Conversation

monopole
Copy link
Contributor

@monopole monopole commented Aug 10, 2021 •
edited

A first attempt to fix #3675

ALLOW_MODULE_SPAN

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 10, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: monopole

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2021
@monopole monopole force-pushed the anchorsAweigh branch 3 times, most recently from 18dc821 to 384f5a0 Compare August 18, 2021 22:58
@monopole monopole changed the title WIP: Add YAML anchor handling Add YAML anchor/alias expansion. Aug 18, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 18, 2021
@monopole
Copy link
Contributor Author

/retest

@natasha41575
Copy link
Contributor

natasha41575 commented Aug 19, 2021 •
edited

unable to retrieve pull request details: GET https://api.github.com/repos/kubernetes-sigs/kustomize/pulls/4114: 403 API rate limit exceeded for 35.202.162.243. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.) [rate reset in 37m37s]make: *** [Makefile:257: test-multi-module] Error 2

I have never seen this error before. Is there a limit to the rate at which we can run the presubmit for a PR?

@monopole
Copy link
Contributor Author

I've never seen it either. Also wondering why this PR as opposed to say 4125

@monopole
Copy link
Contributor Author

/test kustomize-presubmit-master

@monopole monopole merged commit f2f90d1 into kubernetes-sigs:master Aug 24, 2021
@natasha41575
Copy link
Contributor

a bit late, but lgtm

/lgtm

@natasha41575
Copy link
Contributor

/lgtm

@KnVerey
Copy link
Contributor

KnVerey commented Aug 24, 2021

@monopole am I missing something or is this new DeAnchor() functionality not being called in the Kustomization inflation path? If there's still more work to do to hook this up, we should reopen the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KnVerey KnVerey Awaiting requested review from KnVerey

@phanimarupaka phanimarupaka Awaiting requested review from phanimarupaka

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

YAML Anchor support
4 participants
@monopole @k8s-ci-robot @natasha41575 @KnVerey