Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-version compatibility tests #5092

Open
1 of 2 tasks
KnVerey opened this issue Mar 15, 2023 · 2 comments
Open
1 of 2 tasks

Cross-version compatibility tests #5092

KnVerey opened this issue Mar 15, 2023 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/test-coverage Categorizes issue or PR as related to a gap in or problem with our test coverage. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@KnVerey
Copy link
Contributor

KnVerey commented Mar 15, 2023

Eschewed features

  • This issue is not requesting templating, unstuctured edits, build-time side-effects from args or env vars, or any other eschewed feature.

What would you like to have added?

A test suite along the lines of https://github.com/kubernetes/api/tree/master/testdata for the Kustomization type. It could also cover Component, though that uses the same struct at time of writing. Ideally it would also cover built-in transformer types as well, since their schemas are effectively exposed through the generators/transformers fields.

Why is this needed?

To prevent backwards-incompatible and breaking changes from being made to a given version of our APIs (types) across kustomize CLI and module versions. The change in the meaning of the patches is a historical example of what this should prevent:
kubernetes/kubernetes#116598 (comment)

Can you accomplish the motivating task without this feature, and if so, how?

We're currently relying on maintainers knowing the rules and catching violations in code review.

What other solutions have you considered?

If we only need to cover the one core type, maybe we could do something more crude more quickly? Like copy the type as is somewhere and have a test fail with a message about the API change policies to try to help reviewers notice?

Anything else we should know?

No response

Feature ownership

  • I am interested in contributing this feature myself! 🎉
@KnVerey KnVerey added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 15, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 15, 2023
@KnVerey KnVerey added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. kind/test-coverage Categorizes issue or PR as related to a gap in or problem with our test coverage. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 15, 2023
@k8s-triage-robot
Copy link

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/test-coverage Categorizes issue or PR as related to a gap in or problem with our test coverage. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Development

No branches or pull requests

3 participants