Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add namespace option to 'edit add configmap' command #5367

Merged
merged 4 commits into from
Oct 14, 2023
Merged

fix: add namespace option to 'edit add configmap' command #5367

merged 4 commits into from
Oct 14, 2023

Conversation

stormqueen1990
Copy link
Member

  • Add option to include a namespace when adding a ConfigMap via kustomize edit add configmap command.
  • Refactor the constants for flag names to keep a standard between them.
  • Update comment for GeneratorArgs to reflect the usage of the Namespace field.

Fixes #5366

@stormqueen1990
fix: add --namespace flag to edit add configmap
11aa57e 
* Add the option to specify a namespace when using 'kustomize edit add configmap'
  for code parity with 'edit add secret'.
* Rename constants for 'add configmap'/'add secret' so they are standardized.
* Create new constant for the 'namespace' flag.
* Update test cases to cover new scenarios.
@stormqueen1990
docs: update comment to reflect usage of namespace
6ef9773 
Update the comment for the namespace option to reflect its real usage for both
secret and configmap.
@k8s-ci-robot
Copy link
Contributor

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 9, 2023
charles-chenzz
charles-chenzz approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@charles-chenzz charles-chenzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except the format, other LGTM

kustomize/commands/edit/add/configmap.go Outdated Show resolved Hide resolved
@charles-chenzz
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2023
@natasha41575
Copy link
Contributor

natasha41575 commented Oct 13, 2023 •
edited

/hold so you can address #5367 (comment)

Feel free to remove the hold whenever you are ready to merge (and you can ping for another LGTM if needed)

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2023
@stormqueen1990
Copy link
Member Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2023
charles-chenzz
charles-chenzz approved these changes Oct 14, 2023
View reviewed changes
Copy link
Member

@charles-chenzz charles-chenzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charles-chenzz, natasha41575, stormqueen1990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2f99707 into kubernetes-sigs:master Oct 14, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natasha41575 natasha41575 natasha41575 approved these changes

@charles-chenzz charles-chenzz charles-chenzz approved these changes

@koba1t koba1t Awaiting requested review from koba1t

@yuwenma yuwenma Awaiting requested review from yuwenma

Assignees

@natasha41575 natasha41575

@charles-chenzz charles-chenzz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Kustomize Commands outside of `build`
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kustomize edit add configmap does not support specifying namespace
4 participants
@stormqueen1990 @k8s-ci-robot @charles-chenzz @natasha41575