Release manifests still use old registry k8s.gcr.io

[olivierlemasle]

What happened:

Release manifests (components.yaml, ...) still use registry k8s.gcr.io.

$ for version in "0.6.0" "0.6.1" "0.6.2"; do 
  curl -Ls "https://github.com/kubernetes-sigs/metrics-server/releases/download/v${version}/components.yaml" | grep "image:"
done
        image: k8s.gcr.io/metrics-server/metrics-server:v0.6.0
        image: k8s.gcr.io/metrics-server/metrics-server:v0.6.1
        image: k8s.gcr.io/metrics-server/metrics-server:v0.6.2

What you expected to happen:

Release manifests should use registry registry.k8s.io since #1082.

Also see kubernetes/kubernetes#109938

Anything else we need to know?:

make release-manifest generates a components.yaml manifests with image registry.k8s.io/metrics-server/metrics-server:v0.6.0, using Kustomize:

metrics-server/manifests/components/release/kustomization.yaml

Lines 4 to 6 in 9980008

	- name: gcr.io/k8s-staging-metrics-server/metrics-server
	newName: registry.k8s.io/metrics-server/metrics-server
	newTag: v0.6.0

And the CI Release job uses make release-manifests...

Where do the final image registry and tag come from?

/cc @dgrisonnet
/kind bug

[olivierlemasle]

I just saw that the registry has been updated in master branch but not in release-0.6...