Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to exclude nodes by labels #1179

Closed
sergeyshevch opened this issue Jan 25, 2023 · 6 comments · Fixed by #1182
Closed

Add ability to exclude nodes by labels #1179

sergeyshevch opened this issue Jan 25, 2023 · 6 comments · Fixed by #1182
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sergeyshevch
Copy link

What would you like to be added:
#694
We use part of our nodes as AWS EKS Fargate. The metrics server cannot fetch metrics from these nodes. But it still trying to scrape it.
As a result metrics_server_kubelet_request_total{success="false"} reports a high error rate and it's become harder to create correct alerts based on it.

Why is this needed:
It will allow to exclude some nodes and fix issues with failed scrapes in metrics/logs
Screenshot 2023-01-25 at 12 14 35

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 25, 2023
@logicalhan
Copy link
Contributor

/triage accepted
/assign @serathius @dgrisonnet

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jan 26, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 26, 2023
@dgrisonnet
Copy link
Member

@sergeyshevch would you be interested in contributing this change?

@yangjunmyfm192085
Copy link
Contributor

Hi, @sergeyshevch, Do you have time to complete this feature?
If you don't have time to spare, I'd be happy to complete it

@sergeyshevch
Copy link
Author

@dgrisonnet @yangjunmyfm192085 I cannot focus on this in the next few weeks.
@yangjunmyfm192085 Feel free to take this if you want

@dgrisonnet
Copy link
Member

/unassign @dgrisonnet @serathius
/assign @yangjunmyfm192085

@yangjunmyfm192085
Copy link
Contributor

yeah, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants